Conversation
There was a problem hiding this comment.
Pull request overview
Prepares the privacyidea-java-client for the 1.5.0 release by extending challenge/passkey handling, adjusting client-mode based logic, improving async response body handling/logging, and bumping the Maven version.
Changes:
- Update
PIResponsechallenge helpers (pushAvailable,otpMessage,hasChallenges) and customize Gson deserialization forChallenge. - Extend
JSONParserto recognize passkey challenges insidemulti_challenge. - Refactor OkHttp async response consumption to close
ResponseBodyand include HTTP status in logs; bump project version to1.5.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
src/main/java/org/privacyidea/PIResponse.java |
Adds challenge helpers and new filtering logic; introduces a custom Gson deserializer for Challenge. |
src/main/java/org/privacyidea/JSONParser.java |
Adds handling for passkey challenges found in the multi_challenge array. |
src/main/java/org/privacyidea/AsyncRequestCallable.java |
Ensures response bodies are closed and adjusts logging behavior/format. |
pom.xml |
Bumps artifact version to 1.5.0 and changes test execution configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pom.xml
Outdated
| <skipTests>true</skipTests> | ||
| </configuration> |
There was a problem hiding this comment.
Setting Surefire’s <skipTests> to true disables unit tests for all builds, which makes it easy to ship regressions (especially for a release bump). If the intent is only to speed up local packaging, consider removing this change or gating it behind a Maven profile / CI property instead of committing it as the default.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.